Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ci): Add Reviewdog for Prettier formatting #28228

Merged
merged 16 commits into from
Jul 29, 2023
Merged

feat(ci): Add Reviewdog for Prettier formatting #28228

merged 16 commits into from
Jul 29, 2023

Conversation

queengooborg
Copy link
Collaborator

@queengooborg queengooborg commented Jul 27, 2023

This PR introduces reviewdog as a CI workflow to suggest formatting changes to match Prettier's desires, using the reviewdog/action-suggester workflow. This resolves https://github.com/orgs/mdn/discussions/428.

@queengooborg queengooborg requested a review from a team as a code owner July 27, 2023 23:59
@github-actions github-actions bot added the system [PR only] Infrastructure and configuration for the project label Jul 27, 2023
Copy link
Member

@bsmth bsmth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No objections from me, leaving my +1 👍🏻

queengooborg and others added 3 commits July 28, 2023 22:05
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@queengooborg queengooborg requested a review from a team as a code owner July 29, 2023 05:13
@queengooborg queengooborg requested review from dipikabh and removed request for a team July 29, 2023 05:13
@queengooborg queengooborg requested a review from a team as a code owner July 29, 2023 05:16
@github-actions github-actions bot added the Content:Learn:CSS Learning area CSS docs label Jul 29, 2023
@@ -279,7 +279,7 @@ If you nest a block `@layer` at-rule inside another block `@layer` at-rule, with

Let's look at the following example:

```
```css
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note: I am quite literally only including this change because there's an issue with the required test list that prevents infrastructure-only PRs from getting merged. This change is not related to adding Reviewdog, but we have to modify some file in files/ to unblock merging.

@github-actions
Copy link
Contributor

github-actions bot commented Jul 29, 2023

Preview URLs

(comment last updated: 2023-07-29 06:03:48)

queengooborg and others added 2 commits July 28, 2023 22:44
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@queengooborg queengooborg merged commit 38029c1 into main Jul 29, 2023
9 of 10 checks passed
@queengooborg queengooborg deleted the reviewdog branch July 29, 2023 06:42
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Content:Learn:CSS Learning area CSS docs system [PR only] Infrastructure and configuration for the project
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants